Disable OracleConnectionTest#testConnectNoLeak tests #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database See https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai Probable cause is that the service handler gets in a blocked state and is not accepting new connections. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Jan 8, 2025
…-vertx#1482)" This reverts commit c30df2f.
tsegismont
added a commit
that referenced
this pull request
Jan 9, 2025
* Revert "Disable OracleConnectionTest#testConnectNoLeak tests (#1482)" This reverts commit c30df2f. * Reduce number of connections made in testConnectNoLeak tests We only need a few of them to verify whether there is a leak. And we avoid putting to much pressure on the Oracle test DB. Signed-off-by: Thomas Segismont <[email protected]> --------- Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-sql-client
that referenced
this pull request
Jan 9, 2025
* Revert "Disable OracleConnectionTest#testConnectNoLeak tests (eclipse-vertx#1482)" This reverts commit c30df2f. * Reduce number of connections made in testConnectNoLeak tests We only need a few of them to verify whether there is a leak. And we avoid putting to much pressure on the Oracle test DB. Signed-off-by: Thomas Segismont <[email protected]> --------- Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
that referenced
this pull request
Jan 9, 2025
* Revert "Disable OracleConnectionTest#testConnectNoLeak tests (#1482)" This reverts commit c30df2f. * Reduce number of connections made in testConnectNoLeak tests We only need a few of them to verify whether there is a leak. And we avoid putting to much pressure on the Oracle test DB. --------- Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database
See https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai
Probable cause is that the service handler gets in a blocked state and is not accepting new connections.